Alan-Jowett / CoPilot-For-Consensus / 20199303581

79%

push

github

Fix exception handling: Re-raise for transient failures, document intentional recovery (#177)

* Initial plan

* Fix exception handling: re-raise in critical paths, document intentional recovery

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Document intentional exception handling patterns in event handlers

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add tests to verify exception handling patterns

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix test imports and parameter names

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix parameter name inconsistency in publish calls

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix chunking tests to use 'event' parameter instead of 'message'

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix event handlers to re-raise exceptions for transient failures and update tests

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* fix: resolve failing tests in chunking and ingestion services

- Fixed test_end_to_end_chunking and test_oversize_message_handling in chunking/tests/test_integration.py by updating assertions to use 'event' parameter instead of 'message' to match EventPublisher interface
- Fixed test_error_reporter_integration in ingestion/tests/test_service.py to expect and catch ValueError exception
- Fixed test_save_checksums_raises_on_write_error in ingestion/tests/test_service.py by using mock.patch for PermissionError instead of file permissions
- Fixed test_handle_summary_complete_error_handling in reporting/tests/test_service.py to expect exception re-raise for message requeue

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>
Co-authored-by: Alan Jowett <ala... (continued)

11 of 15 new or added lines in 7 files covered. (73.33%)

1090 of 1295 relevant lines covered (84.17%)

0.84 hits per line