zalando / skipper / 20169950306

78%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: admission test to use synctest (#3783)

- Replace real network connections with fake network pipes and listeners
to enable controlled simulation of network behavior. Implementation is
taken from https://go.dev/src/net/http/netconn_test.go
- Fix the loop in admissionControl ticker, we were checking the quit
channel only on tick instead of waiting for one of the two conditions.
- Simplify `TestAdmissionControl`. We control rand and time and can
expect exact values.

ref https://github.com/zalando/skipper/issues/2386

---------

Signed-off-by: Aleksandr Ponimaskin <aleksandr.ponimaskin@zalando.de>

Run Details

22 of 26 new or added lines in 2 files covered. (84.62%)

77 existing lines in 7 files now uncovered.

24518 of 31269 relevant lines covered (78.41%)

87981.07 hits per line