Alan-Jowett / CoPilot-For-Consensus / 20155523940

82%

push

github

feat: Add ValidatingEventSubscriber and integrate schema validation in parsing service (#101)

* feat: add ValidatingEventSubscriber and integrate schema validation in parsing service

- Add ValidatingEventSubscriber wrapper for inbound event validation
- Integrate ValidatingEventSubscriber in parsing service
- Add copilot_schema_validation to parsing service dependencies
- Use ValidatingEventPublisher for outbound events
- Use ValidatingDocumentStore for storage operations
- Provides comprehensive schema validation defense across event lifecycle

* fix: address PR review comments for ValidatingEventSubscriber

- Fix connect() return type to match EventSubscriber interface (returns None, raises on failure)
- Use Tuple from typing module for type hint consistency
- Make subscribe() parameters required (event_type and callback)
- Add comprehensive test suite for ValidatingEventSubscriber (25 test cases)
  - Tests for initialization, validation logic, callback wrapping
  - Tests for strict/non-strict modes and error handling
  - Tests for edge cases (missing schemas, malformed events)
  - Integration tests for full event subscription flow

* fix: correct validate_json mock patch path in tests

- Patch copilot_schema_validation.validate_json instead of copilot_events.validating_subscriber.validate_json
- validate_json is imported dynamically inside _validate_event method, not at module level
- Fixes AttributeError in test suite (8 failing tests)

---------

Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>

69 of 76 new or added lines in 2 files covered. (90.79%)

286 of 447 relevant lines covered (63.98%)

0.64 hits per line