orion-ecs / keen-eye / 20144864443

65%

push

github

fix: Remove .ToList() anti-pattern from sample systems

Resolves #215

Changes:
- Added explanatory comment block at top of Systems.cs explaining CommandBuffer pattern
- Removed unnecessary .ToList() calls from 6 systems where CommandBuffer already defers structural changes
- Fixed documentation example in command-buffer.md showing the same anti-pattern
- Added 4 comprehensive tests demonstrating proper direct iteration patterns with CommandBuffer

The CommandBuffer pattern allows safe direct iteration without materializing lists,
preventing allocation on every frame while maintaining iterator safety. Only CleanupSystem
and CollisionSystem still use .ToList() where actually required (Despawn() invalidates
iterators, and nested iteration needs one snapshot for performance).

Co-authored-by: Tyler Coles <tyevco@users.noreply.github.com>

1162 of 1235 branches covered (94.09%)

Branch coverage included in aggregate %.

6430 of 6761 relevant lines covered (95.1%)

1.29 hits per line