Qiskit / qiskit / 20138746935

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add ways to iterate over the `Target` in C. (#15208)

* POC: Add ways to iterate over the target in C.

* [POC 2] Use indexing to avoid extra structs.
- Add tests.

* Fix: Avoid using const size ptr for windows

* Docs: Add docstring for each method.

* Fix: Formatting issues

* Docs: Add release note

* Fix: Address review comments

Co-authored-by: Kevin Hartman <kevin@hart.mn>

* Remove: QkQargs
- Update documentation, docstrings, and tests to reflect the change.

* Chore: Rename `inst_idx` to `op_idx`.

* Docs: Document missing arg

* Docs: Add missing return values.

* Fix: Remove exit codes.
- Based on offline discussion, the need for `IndexError` `ExitCode` here is unwarranted. We should instead default to panicking as it is okay to stop the program if an index is wrong.

* Fix: Address review comments

* Fix: Additional review comments

* Fix: More review comments
- Fix some documentation docstrings and error messages during C testing.

* Fix: C format

* FIx: Offline review items
- Remove `contains` methods.
- Remove `_get` suffix/prefix.

* Change `qargs_len` type to `uint32_t`

This avoids specifying the return value of `qargs_len` in the case of a
global operation, since we already commit to the only possible return
value of the pointer being null iff the properties are global.
Returning `uint32_t` is more consistent with our other use of
`qargs_len`, and we can still use `u32::MAX` as a length if we choose.

---------

Co-authored-by: Kevin Hartman <kevin@hart.mn>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Run Details

88 of 101 new or added lines in 2 files covered. (87.13%)

9 existing lines in 5 files now uncovered.

96431 of 109212 relevant lines covered (88.3%)

1206918.54 hits per line