Qiskit / qiskit / 20140426167

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add `qk_dag_compose` to the C API (#15329)

* Initial: Add `qk_dag_compose` to the C API

* Test: Add one test
The test is based on the ``test_compose_inorder`` python test, but it is incomplete since we cannot check the order of the operations just yet. However, we can easily check the number of operation nodes as a temporary way of checking the validity of the composition.

* Apply suggestions from code review

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

* Fix: Use `std::slice::from_raw_parts`.

* Fix: Add extra test with qubit re-ordering.

* Fix: Finalize test by adding clbit reordering.

* Fix: memory leak in test_dag.c

* Docs: Add example in docstring

* Fix: Incorrect comparison
- Remove classical registers when not needed.

* Fix: C format

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* FIx: Remove `num_qubits` and `num_clbits`
- Fix error message for general failure in compose.

* Apply suggestion from @Cryoris

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Small docs & test fixes

- expand exit code return
- fix goto statement missing expected_dag
- improve consistency treating qubit and clbit

---------

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>

Run Details

48 of 53 new or added lines in 1 file covered. (90.57%)

4 existing lines in 1 file now uncovered.

96508 of 109265 relevant lines covered (88.32%)

1203522.02 hits per line