zalando-incubator / kube-ingress-aws-controller / 20138505381

72%

master: 72%

Pull #766

github

Enable Support for creating Dual Stack NLB

This PR Enables Support for creating Dual Stack NLB.

This is required for Enabling AWSCNI mode in EKA IPv6 clusters. For AWSCNI mode to be enabled in an IPv6 cluster we need to have IPv6 target groups. And IPv6 target groups can only be attached to a `dualstack` load balancer.

There is already a flag `--ip-addr-type` to control the ALB IP address type but for NLB we hard code it to `ipv4`, this PR just removes the hardcoding and passes the flag value. It also adds a new annotation `ingress.kubernetes.io/ip-address-type` so that users are able to control the IP Address Type for the NLB and deprecates the existing annotation `alb.ingress.kubernetes.io/ip-address-type`.

Signed-off-by: speruri <surya.srikar.peruri@zalando.de>

3 of 4 new or added lines in 2 files covered. (75.0%)

2856 of 3989 relevant lines covered (71.6%)

11.0 hits per line