facet-rs / facet / 20069503463

58%

Build Type

push

github

Committed by fasterthanlime

Commit Message

fix(facet-args): handle Option<T> positional arguments correctly

Previously, when parsing a positional argument into an Option<String>
or Option<T> field, facet-args would try to call `parse_from_str` on
the Option type directly, which failed because Option doesn't implement
FromStr.

This fix adds a case in `handle_value` to detect `Def::Option` and
properly wrap the parsed value in `Some` by:
1. Calling `begin_some()` to enter the Some variant
2. Parsing the inner value
3. Calling `end()` to close the Some

Also adds a regression test and updates the snapshot for the
"multiple values for Option" error case (which now correctly
reports "unexpected positional" instead of "cannot be parsed").

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

26175 of 44564 relevant lines covered (58.74%)

635.66 hits per line