facet-rs / facet / 20068996792

58%

push

github

fix: remove Box::leak in facet-value PathSegment conversion

Change PathSegment in facet-pretty to use Cow<'static, str> instead of
&'static str. This allows:

- Static strings from Shape metadata (common case) to remain zero-cost
  with Cow::Borrowed
- Owned strings from deserialization errors to work without memory leaks
  using Cow::Owned

Previously, converting facet-value's PathSegment (which uses owned String)
to facet-pretty's PathSegment (which expected &'static str) required
Box::leak, causing memory to leak on every error diagnostic.

Closes #1178

13 of 17 new or added lines in 1 file covered. (76.47%)

26173 of 44561 relevant lines covered (58.74%)

635.64 hits per line