ghga-de / notification-service / 20059788712

89%

push

github

Scissor grinder cicada (#32)

* Init

* Fix newline

* Hooks

* Add Lox24 OpenAPI spec

* Format

* Accidentally removed that

* Move constants to top; apply indirect parametrization to avoid duplication of fixtures

* Separate notification_type in sms_notification_type and email_notification_type

* Add test that only sms is send

* Rename error, update docstrings

* Rename adapter and refactor config

* Log response uuid, remove _add_auth_headers, add status codes, add integration test, don't set reponse internally

* Remove underscore

* Merge message directly

* Fix typo

* Update dependencies, bump major, run scripts

* Remove data

* Use typed dict to satisfy mypy

* Revert changes in joint fixure and remove dlq test

* Mock sms client

* Rename test_basic to test_email

* Replace with AsyncMock

* Update src/ns/adapters/outbound/lox24_client.py

Co-authored-by: Byron Himes <thebyronhimes@gmail.com>

* Update function signature

* Remove dict

* Fix message, wrap _raise_for_status in try/error and log response payload

* Harmonize

* Update src/ns/core/notifier.py

Co-authored-by: Byron Himes <thebyronhimes@gmail.com>

* Remove integration test

* Refactor config

* Remove unnecessary constructor

* Linter

---------

Co-authored-by: Byron Himes <thebyronhimes@gmail.com>

95 of 97 new or added lines in 7 files covered. (97.94%)

317 of 358 relevant lines covered (88.55%)

0.89 hits per line