ghga-de / notification-service

89%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• 0.1.0
• 0.1.1
• 0.1.2
• 1.0.0
• 1.1.0
• 1.1.1
• 1.1.2
• 1.1.3
• 1.2.0
• 2.0.0
• 2.1.0
• 3.0.0
• 3.0.1
• 3.0.2
• 3.0.3
• 4.0.0
• 4.0.1
• 4.0.2
• 5.0.0
• 5.0.1
• add_debug_logging
• feature/add_handover_documentation_GSI-154
• feature/consume_notification_events_GSI-7
• feature/enable_dlq_GSI-1394
• feature/hexkit_v4_GSI-1340
• feature/hexkit_v6_GSI-1748
• feature/html_email_template_config_GSI-19
• feature/idempotence_GSI-626
• feature/improve_auth_config_GSI-953
• feature/initialize_repo-GDEV-1803
• feature/pydantic_v2_GSI-524
• feature/remove-empty-recipients
• feature/sanitize_input_GSI-900
• feature/scissor-grinder-cicada
• feature/send_email_notifications_GSI-9
• feature/smtp_timeout_GSI-986
• feature/standardized_event_config_GSI-1448
• feature/stmp_without_auth_GSI-949
• feature/template_update
• feature/update-dependencies
• feature/update-py-and-deps
• feature/update-template
• feature/update_idempotence_GSI-930
• feature/use-starttls-config-GIM-301
• feature/use_json_logging_GSI-557
• fix/h11_patch
• fix/update_lock_files
• fix_dockerfile
• main
• template_migration_GSI-380
• update_dependencies
• update_to_hexkitv5
• update_to_python3-12

Build # 20059788712

Build Type

push

github

Committed by web-flow

Commit Message

Scissor grinder cicada (#32)

* Init

* Fix newline

* Hooks

* Add Lox24 OpenAPI spec

* Format

* Accidentally removed that

* Move constants to top; apply indirect parametrization to avoid duplication of fixtures

* Separate notification_type in sms_notification_type and email_notification_type

* Add test that only sms is send

* Rename error, update docstrings

* Rename adapter and refactor config

* Log response uuid, remove _add_auth_headers, add status codes, add integration test, don't set reponse internally

* Remove underscore

* Merge message directly

* Fix typo

* Update dependencies, bump major, run scripts

* Remove data

* Use typed dict to satisfy mypy

* Revert changes in joint fixure and remove dlq test

* Mock sms client

* Rename test_basic to test_email

* Replace with AsyncMock

* Update src/ns/adapters/outbound/lox24_client.py

Co-authored-by: Byron Himes <thebyronhimes@gmail.com>

* Update function signature

* Remove dict

* Fix message, wrap _raise_for_status in try/error and log response payload

* Harmonize

* Update src/ns/core/notifier.py

Co-authored-by: Byron Himes <thebyronhimes@gmail.com>

* Remove integration test

* Refactor config

* Remove unnecessary constructor

* Linter

---------

Co-authored-by: Byron Himes <thebyronhimes@gmail.com>

Run Details

95 of 97 new or added lines in 7 files covered. (97.94%)

317 of 358 relevant lines covered (88.55%)

0.89 hits per line