cybertec-postgresql / pgwatch / 20057707181

74%

Build Type

push

github

Committed by web-flow

Commit Message

[*] migrate all helpers to `testutil` (#1071)

* Move `sources` package helper functions to `testutil`.

* Move all helpers in `webserver` package to `testutil`.

* Add tests for `Mock{Sources,Metrics}ReaderWriter` to increase test coverage.

* Use `testutil` instead of manual container setup.

* Use testutil `helpers` instead of manually creating mocks/containers.

* Remove `TestSetupRPCServers()`

The setup function should be invoked once across all tests
because it setups a global port listener,
otherwise running tests parallely
may fail with `address already in use` error.

* Add tests to increase test coverage.

* remove `testutil.ExpectQuery`, overruled by #1067

* move `createTestSourceConn()` back to reaper

* Set etcd container version in `EtcdVersion` const.

It maybe useful for logging.

* Revert moving `mockFs` to `testutils`.

* Revert signature change in `createTestSourceConn()`

* Fix line spacing.

---------

Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>

Run Details

64 of 64 new or added lines in 2 files covered. (100.0%)

26 existing lines in 1 file now uncovered.

3804 of 5154 relevant lines covered (73.81%)

0.84 hits per line