knex / knex / 20025465889

93%

push

github

Ensure CRDB has the expected database before running integration tests (#6311)

* Ensure CRDB has the expected database before running integration tests

* Use a global root "before" hook instead of a fake "it" block

I noticed that crdb tests still failed with this problem when
using describe.only to target tests. I had previously tried
a "before" hook inside a "describe" block, but it turns out
just a raw "before" at the root does work both for running
all tests and for running selected tests.

* Perform database prep for tape tests too

* Clean up promise handling

Fail at the first prepDB failure, instead of synchronously launching
a bunch of dangling promises. We still crash out with an uncaught
rejection if one fails, but the asynchronous flow is much clearer
this way, and we don't run along trying to register and possibly
kick off more tests after encountering a failure

3562 of 4206 branches covered (84.69%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 2 files covered. (100.0%)

14717 of 15433 relevant lines covered (95.36%)

2373.32 hits per line