knex / knex / 20025388201

93%

push

github

Fix various failing tests (#6313)

* Update test to match both old and new error descriptions

I'm assuming this test used to pass, but the error message I get from
the version of oracle using the documented setup includes "or closed".
Change to a regex that matches either.

* MSSQL: Drop "test" table before each run

For some reason, the "afterEach" hook is not enough to leave the
database clean of this table which is used in the "column default
handling" tests. Ensure it's removed before running the tests.

* General: Drop extra integration test tables in cleanup

In Oracle, dropping the "accounts" table was failing because it was
referenced by the "test_foreign_table_two" table (which is created
in the schema/misc tests). Ensure it is dropped so that accounts
can be dropped as expected.

I also identified "check_test" as another table being created by
raw tests (and not the tableCreatorHelper code) and added it to
the list of tables to clean up.

* MySQL: ensure query contents are unique for timeout tests

The last timeout test, which abandons the connection, was leaving
the sleep query running. Since both "mysql" and "mysql2" drivers
are connecting to the same database for integration testing, when
both were executed in the same test run, some "mysql2" tests were
seeing these hanging queries and failing, when they were actually
started by a different test against a different database client.

I added comments to the queries to ensure that they are unique
per-test and per-driver, so that the timeout tests are only
asserting against their own queries.

* Use a proper port number for connection string parse assertions

`parse-connection.js`'s `tryParse` uses `new URL` to parse URLs.
Even though the "port" property of a URL instance is a string,
the string is of a non-zero-prefixed integer. These tests were
failing since they asserted that "0000" parsed to "0000", but
in actuality they parsed to "0". Rather than adjust the test
to expect "0", I change... (continued)

3543 of 4202 branches covered (84.32%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

14672 of 15417 relevant lines covered (95.17%)

1957.26 hits per line