kubevirt / hyperconverged-cluster-operator / 20004527574

76%

Build Type

push

github

Committed by web-flow

Commit Message

Split the own-resources logic from ClusterInfo interface (#3892)

* Introduce new fake ClusterInfo

Add a new ClusterInfo mock, with several benefits:
1. new optional API, to be flex and math the specific test.
2. have it's own package, to ease importing it, and avoid cycle import
   errors.

The new mock will slowly replace the curewnt one, until we could remove
it. Currently the API is very limited. we'll add more options when
needed, in each the specific test will start using it.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Split the own-resources logic from ClusterInfo

Introduce the new pkg/ownreference package, with the logic of the
ClusterInfo own-reference logic, to later take it out from the
ClusterInfo implementation and API.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* add mocks for the ownresources package

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* use the ownreference package instead of ClusterInfo

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* cleanup ClusterInfo

Remove the own-reference methods from the the ClusterInfo interface and
implementations.

Remove the own-reference logic from the util package.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

Run Details

171 of 263 new or added lines in 11 files covered. (65.02%)

7 existing lines in 1 file now uncovered.

8083 of 10536 relevant lines covered (76.72%)

1.82 hits per line