mozilla-releng / balrog / #5052

90%

main: 89%

push

circleci

Don't change render state while filtering releases (#3589)

Every state changes triggers a state change, which gets react to create N
objects which get increasingly bigger (the spread operator with
...prevState). With 1000 releases, that's 500k copies. With 60k which is
what I'm testing with... `> sum(range(0, 60001)) = 1800030000` (yikes).
And that's not counting the state changes queuing re-renders, one per
release... Even if react batches those, it's again copies, and extra
work.

This commit changes it to create the state in one go, making filtering
60k releases actually something doable rather than something that will
freeze firefox for 30s for every typed character

2165 of 2546 branches covered (85.04%)

Branch coverage included in aggregate %.

5730 of 6236 relevant lines covered (91.89%)

0.92 hits per line