facet-rs / facet / 19945465478

58%

push

github

fix(facet-kdl): skip solver disambiguation when variant matched by node name

When deserializing Vec<Enum> with #[facet(kdl::children)], the node name
should be used as the variant discriminator. Previously, even after
successfully matching a variant by node name (e.g., "save-screenshot" →
SaveScreenshot), the code would still invoke the solver for enum
disambiguation. This caused "Ambiguous" errors when variants had
identical field structures.

The fix checks if a variant has already been matched by node name
(variant_fields.is_some()) and skips solver-based disambiguation in
that case - the node name already told us which variant to use.

Fixes an issue where this KDL:
```kdl
keymap {
    save-screenshot keys=s
    copy-to-clipboard keys=<enter>
}
```

Would fail with "Ambiguous: multiple resolutions match" because both
SaveScreenshot and CopyToClipboard have identical `keys: String` fields.

2 of 2 new or added lines in 1 file covered. (100.0%)

22801 of 39475 relevant lines covered (57.76%)

502.57 hits per line