19944716089
58%

Ran 04 Dec 2025 09:37PM UTC

Jobs 1

Files 190

Run time 1min

Badge

Embed ▾

Committed 04 Dec 2025 09:35PM UTC coverage: 57.749% (+0.03%) from 57.723%

Build # 19944716089

Build Type

push

github

Committed by

fasterthanlime

Commit Message

fix(facet-reflect): remove unused steal_nth_field and fix default handling

This commit:
- Removes steal_nth_field method which was never used outside tests
- Removes HeistCancelledDifferentShapes error variant
- Updates fill_defaults to return Result and error when a field has
  #[facet(default)] but no default can be provided
- Keeps `make_t or $ty::default()` grammar which correctly uses the
  Rust field type's Default impl (not the Facet shape's)

The key insight: for opaque fields like `#[facet(opaque)] d: Option<T>`,
the grammar generates code using `Option<T>::default()` (which is None),
not `Opaque<Option<T>>::default()` (which doesn't exist).

Fixes #1075

Run Details

22796 of 39474 relevant lines covered (57.75%)

502.5 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	77.42	-9.68%	facet-reflect/src/partial/iset.rs
36	77.92	-1.35%	facet-reflect/src/partial/mod.rs
142	65.33	1.4%	facet-macros-impl/src/attr_grammar/make_parse_attr.rs
146	74.84	-0.46%	facet-reflect/src/partial/partial_api/misc.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	19944716089.1	04 Dec 2025 09:37PM UTC	190	57.75	GitHub Action Run

facet-rs / facet / 19944716089
58%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 19944716089

facet-rs / facet / 19944716089 58%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 19944716089

facet-rs / facet / 19944716089
58%

README BADGES
x