stacklok / toolhive / 19892531401

59%

Build Type

push

github

Committed by web-flow

Commit Message

Fix VirtualMCPServer OIDC configuration by implementing OIDCConfigurable interface (#2821)

* Add mockgen directive for OIDC Resolver interface

Add go:generate directive to generate gomock mock for the oidc.Resolver
interface. This enables proper unit testing of components that depend on
OIDC resolution without requiring a real Kubernetes client.

* Add OIDCConfigurable interface implementation to VirtualMCPServer

Implement GetOIDCConfig() and GetProxyPort() methods on VirtualMCPServer
to satisfy the oidc.OIDCConfigurable interface. This allows the OIDC
resolver to resolve Kubernetes and ConfigMap OIDC configurations for
VirtualMCPServer resources.

GetProxyPort returns 4483, the default vMCP server port.

* Refactor Converter to require OIDC resolver for all OIDC types

Previously, the Converter only handled inline OIDC configuration directly
and had a TODO for kubernetes and configMap types. This change:

- Makes oidcResolver a required parameter for NewConverter (returns error
  if nil)
- Uses the resolver for all OIDC types (kubernetes, configMap, inline)
- Adds mapResolvedOIDCToVmcpConfig() to map resolver output to vmcp config
- Handles ClientSecretEnv for all OIDC types that may have client secrets
- Updates controller to pass OIDC resolver to converter
- Adds comprehensive tests using gomock for OIDC resolution
- Adds compile-time interface assertion for VirtualMCPServer

This ensures fail-closed behavior: if OIDC is configured but resolution
fails, the converter returns an error rather than silently deploying
without authentication.

Run Details

64 of 145 new or added lines in 4 files covered. (44.14%)

14 existing lines in 1 file now uncovered.

26055 of 51994 relevant lines covered (50.11%)

60.29 hits per line