loot / loot-condition-interpreter / 19803524316

90%

master: 90%

Build Type

push

github

Committed by Ortham

Commit Message

Remove pelite dependency

The advantages of using object instead of pelite are:

- It's 1 dependency instead of 8
- It's 57474 unaudited lines of code instead of 240715 (though if I swap out winapi for windows-sys that drops to 59392, since windows-sys is also used by other dependencies)
- object seems to be better maintained - it's had a few releases this year, while pelite hasn't had any in 3 years, and my PR for replacing winapi hasn't had any response in the month and a half it's been open
- object is more popular, with 238 dependents vs 33, and though it's about half a year newer it's got about 600x more downloads

I'm not sure how much heavy lifting object is doing for me - it might not be too much effort to do everything I need without it.

Run Details

6 of 6 new or added lines in 1 file covered. (100.0%)

13 existing lines in 2 files now uncovered.

4345 of 4832 relevant lines covered (89.92%)

29.7 hits per line