stacklok / toolhive / 19769886661

50%

Build Type

push

github

Committed by web-flow

Commit Message

Issue 2680 (#2757)

* Improve error messaging when DCR is unsupported for remote MCP servers

Add clear, actionable error messages when OAuth providers do not support
Dynamic Client Registration (DCR), helping users understand why authentication
fails and how to configure client credentials manually.

Changes:
- Detect missing registration_endpoint in OIDC discovery document
- Recognize HTTP status codes indicating DCR is unavailable (404, 405, 501)
- Provide actionable guidance directing users to --remote-auth-client-id and --remote-auth-client-secret flags
- Add comprehensive test coverage for all DCR unsupported scenarios

Error message improvements:
- Before: "dynamic client registration failed with status 404: {...}"
- After: "this provider does not support Dynamic Client Registration (DCR) - HTTP 404. Please configure OAuth client credentials using --remote-auth-client-id and --remote-auth-client-secret flags, or register a client manually with the provider"

Fixes #2680

Signed-off-by: 4t8dd <wanger.xyz@gmail.com>

* fix the lint errors

Signed-off-by: 4t8dd <wanger.xyz@gmail.com>

---------

Signed-off-by: 4t8dd <wanger.xyz@gmail.com>

Run Details

20 of 20 new or added lines in 2 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

25697 of 51453 relevant lines covered (49.94%)

59.8 hits per line