stacklok / toolhive / 19766671961

50%

push

github

Two minor fixes for vMCP retryDelay handling (#2795)

* Add webhook validation for RetryDelay field

Add admission-time validation for the RetryDelay field in
VirtualMCPServer composite tool error handling. This ensures
invalid duration formats are rejected with clear error messages
instead of silently failing during conversion.

Changes:
- Add RetryDelay format validation in validateStepErrorHandling()
- Reuse existing validateDuration() from the same package
- Add tests for valid durations (5s, 1m30s) and invalid formats

* Add error logging for RetryDelay parsing failures

Log a warning when RetryDelay duration parsing fails in the converter.
This improves debugging by making it clear when an invalid duration
is silently defaulting to zero, even though webhook validation should
catch invalid formats at admission time.

* Add ErrorAction constants for workflow error handling

Define ErrorActionAbort, ErrorActionContinue, and ErrorActionRetry
constants to replace string literals in webhook validation code.
This addresses a goconst linter warning about repeated string usage
and improves code maintainability.

21 of 22 new or added lines in 3 files covered. (95.45%)

25682 of 51435 relevant lines covered (49.93%)

60.2 hits per line