agama-project / agama / 19635098277

54%

master: 75%

Build Type

push

github

Committed by web-flow

Commit Message

Fixed missing translations (bsc#1250059) (#2904)

## Problem

- Some missing translations in the web UI
- https://bugzilla.suse.com/show_bug.cgi?id=1250059#c0

## Details

The code at the top level like

```
const message = _("foo")
```
does not work properly because the code is evaluated too early, even
before the component is actually displayed and before the translations
are loaded from the server.

## Solution

There are basically two solutions:

1. Use `N_()` function instead of `_()` at the top level and then use
`_()` when using the constant later.
2. Move the constant into a function (or function component) which is
called (and evaluated/retranslated) in every rendering of the component.

## Testing

- Tested manually.
- Because most of the problems were in special storage technologies like
iSCSI or DASD I was able to test only the error message in the software.
And even that was a bit tricky, to trigger the error I configured an
invalid installation repository with the
`inst.instal_url=http://example.com` boot parameter.
- I also verified the generated POT file after this change to ensure no
translation was lost. The generated POT is the very same (except the
line numbers in comments) as before the change.

## Additional changes

- Enabled eslint check which finds the top level translations to avoid
similar problems in the future
- Use NodeJS v22 in the CI build, that's the same version as in SLE-16.
Moreover v18 is obsolete and out of support for several months.
:open_mouth:

## Screenshots

Original SLE-16 system without the patch:
<img width="1280" height="800" alt="agama-missing-translation-software"
src="https://github.com/user-attachments/assets/2244b15e-3c5f-486d-b118-d5c84a7bdb0f"
/>

Fixed system after applying this patch:
<img width="1280" height="800"
alt="agama-missing-translation-software-fixed"
src="https://github.com/user-attachments/assets/7865c79e-7868-4614-8146-2f8da20f3ffe"
/>

---------

Co-authored-by: Martin Vidner <mvidner@suse.com>

Run Details

2228 of 4007 branches covered (55.6%)

Branch coverage included in aggregate %.

9 of 10 new or added lines in 8 files covered. (90.0%)

11 existing lines in 6 files now uncovered.

25316 of 38840 relevant lines covered (65.18%)

50.26 hits per line