kobotoolbox / kpi / 19572786077

81%

master: 76%

push

github

fix(submission): handle missing xml file with digest authentication DEV-1038 (#6428)

### 📣 Summary
Prevent server errors when clients using Digest authentication send
empty submission requests to the openrosa `/<username>/submission`
endpoint.

### 📖 Description
Previously, when a client (such as curl using --digest) attempted to
submit to `https://kobocat/<username>/submission` for a form that does
not allow anonymous submissions, the first unauthenticated request in
the Digest handshake was accepted by the view.

Because this initial request contained no body and no authentication
header, the view attempted to read a `None` file instance, leading to:

```
AttributeError: 'NoneType' object has no attribute 'read'
```
This caused a 500 error before the client’s second (authenticated)
request could be processed.

This PR adds a validation to check whether `xml_file` is missing or
empty. When this happens, the server now fails fast with a proper
`OpenRosaResponseBadRequest (400)` and a clear, informative error
message.

7104 of 11156 branches covered (63.68%)

4 of 4 new or added lines in 1 file covered. (100.0%)

27449 of 33752 relevant lines covered (81.33%)

1.6 hits per line