iotaledger / iota / 19556932824
63%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1431
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.916% (-0.009%) from 65.925%
19556932824

push

github

web-flow 
fix(docker): determine build script location to resolve relative paths correctly (#9144)

# Description of change

The docker build scripts invoke another script using a relative path, so
running them from some other directory, different from their location,
will not work. For example, the instructions we have here
https://github.com/iotaledger/iota/tree/develop/dev-tools/iota-private-network#1-build-docker-images
do not work (__at least on Linux__) exactly because of this problem.
This PR adds changes to determine docker build scripts' location so that
relative paths used in the scripts can be resolved correctly.

## How the change has been tested

Build a docker image, for example `iota-node`, from different working
directories:

- From the root directory of the monorepo:

   ```sh
   cd $(git rev-parse --show-toplevel)
   docker/iota-node/build.sh -t iota-node --no-cache
   ```

On `develop`, the build command fails with `docker/iota-node/build.sh:
line 5: ./../utils/build-script.sh: No such file or directory`.

- From the `dev-tools/iota-private-network` directory as instructed
[here](https://github.com/iotaledger/iota/tree/develop/dev-tools/iota-private-network#1-build-docker-images):

   ```sh
   cd "$(git rev-parse --show-toplevel)/dev-tools/iota-private-network"
   ../../docker/iota-node/build.sh -t iota-node --no-cache
   ```

On `develop`, the build command fails with
`../../docker/iota-node/build.sh: line 5: ./../utils/build-script.sh: No
such file or directory`.

- From the `docker/iota-node` directory:

   ```sh
   cd "$(git rev-parse --show-toplevel)/docker/iota-node"
   ./build.sh -t iota-node --no-cache
   ```

Only this build command seems to work on `develop`, meaning that we must
first navigate to the build script directory and then run the script
from there.

---------

Signed-off-by: Roman Overko <roman.overko@iota.org>

236540 of 358848 relevant lines covered (65.92%)

2354377.76 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
73.04
 -0.14% crates/iota-core/src/execution_cache.rs
1
95.37
 -0.23% crates/iota-core/src/signature_verifier.rs
1
86.9
 0.0% crates/iota-network/src/discovery/mod.rs
2
57.04
 -0.47% crates/iota-core/src/storage.rs
2
75.53
 -1.06% crates/iota-grpc-server/src/types.rs
3
85.26
 -0.44% consensus/core/src/network/tonic_network.rs
3
96.51
 -0.5% crates/iota-core/src/quorum_driver/tests.rs
3
88.69
 -1.79% crates/iota-surfer/src/surfer_state.rs
3
93.79
 -0.14% crates/starfish/core/src/transactions_synchronizer.rs
6
86.06
 -1.13% crates/iota-core/src/consensus_handler.rs
9
66.67
 -18.75% crates/iota-network-stack/src/anemo_ext.rs
10
78.18
 -9.09% crates/iota-surfer/src/surf_strategy.rs
14
0.0
 -48.28% crates/iota-types/src/storage/error.rs
15
87.25
 -0.77% consensus/core/src/synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 19556932824.1 1433
65.91
 GitHub Action Run
Source Files on build 19556932824