19538920465
88%

Ran 20 Nov 2025 01:57PM UTC

Jobs 1

Files 514

Run time 2min

Badge

Embed ▾

Committed 20 Nov 2025 01:42PM UTC coverage: 87.63% (-0.02%) from 87.648%

Build # 19538920465

Build Type

push

github

Committed by

sergepetrenko

Commit Message

limbo: make txn_limbo_confirm nop during fencing

Before this patch a synchronous transaction could be confirmed when user
lowered `replication_synchro_quorum` while limbo is in the frozen state.
It could lead to the next situation:
1) server1 loses a quorum of connections and its limbo goes into the
   frozen state.
2) The new elected master rollbacks a non-confirmed synchronous
   transaction.
3) On the old master we lower `replication_synchro_quorum` to 1. Our
   synchronous transaction is confirmed because our node can collect
   sufficient number of acks.
As a result, we have inconsistent state in the replicaset because on the
old master we have a confirmed transaction but on the new master we have
a rolledbacked transaction.

Now, we fix this issue by returning from the `txn_limbo_confirm` when
`txn_limbo_is_frozen` is true. It can help us to make the
`txn_limbo_confirm` - nop and not confirm synchronous transactions.

Needed for tarantool#11574

NO_DOC=bugfix
NO_CHANGELOG=<not released>

Run Details

70137 of 118117 branches covered (59.38%)

2 of 2 new or added lines in 1 file covered. (100.0%)

225 existing lines in 16 files now uncovered.

105294 of 120157 relevant lines covered (87.63%)

1349248.43 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	88.96	-0.61%	src/box/engine.c
1	96.88	-1.56%	src/box/engine.h
1	95.83	-0.12%	src/box/replication.cc
1	90.14	-0.08%	src/box/vy_log.c
1	88.01	0.01%	src/box/vy_run.c
1	85.86	0.08%	src/box/xlog.c
1	97.56	0.0%	src/lib/msgpuck/msgpuck.h
2	92.57	0.13%	src/box/vinyl.c
2	88.72	-0.3%	src/box/vy_lsm.c
2	89.36	-0.11%	src/box/xrow.c
2	85.94	-0.27%	src/lib/core/say.c
2	85.71	-9.52%	src/lib/core/tt_sigaction.c
3	90.9	-0.31%	src/box/vy_scheduler.c
3	22.66	-0.04%	src/lib/uri/uri_parser.c
15	91.91	-1.81%	src/box/memtx_space.c
187	90.86	-0.52%	src/box/box.cc

Jobs

ID	Job ID	Ran	Files	Coverage
1	19538920465.1	20 Nov 2025 01:57PM UTC	514	87.63	GitHub Action Run

tarantool / tarantool / 19538920465
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 19538920465

tarantool / tarantool / 19538920465 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 19538920465

tarantool / tarantool / 19538920465
88%

README BADGES
x