tarantool / tarantool / 19532453962

88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

netbox: reduce spam in netbox logs

Before this patch a lot of "Connection refused" records were printed in
log files during netbox connection. This happened in two general
situations:
1) Current instance tries to connect to non-existent instance.
2) Current instance loses a succeeded connection to another instance.

The spam in logs was appearing because we didn't have any logic in
`netbox_worker_f` which would control periodic errors' logging during
netbox connection.

Now, we fix this issue by passing a whole error object into lua stack
instead of errmsg and changing logic of errors' displaying in `new_sm`
netbox lua function. We display error in "warning" mode only if
1) This error is the first one in netbox session.
2) Current and previous error has different types (codes).
3) Current and previous error has different messages and different types
   of parent error.

Otherwise, current error will be repeated in "verbose" mode.

Closes #10506

NO_DOC=bugfix

Run Details

70126 of 118099 branches covered (59.38%)

3 of 3 new or added lines in 1 file covered. (100.0%)

24 existing lines in 12 files now uncovered.

105314 of 120155 relevant lines covered (87.65%)

1350754.83 hits per line