cybertec-postgresql / pgwatch / 19436814112

74%

push

github

[*] deprecate `--direct-os-stats` flag (#1024)

* deprecate `--direct-os-stats` flag. Direct OS stats are now fetched
automatically when pgwatch runs on the same host as PostgreSQL.

- `IsDirectlyFetchableMetric()` now auto-detects same-host
- Removed `r.Metrics.DirectOSStats` flag checks from reaper
- Added `SourceConn.IsClientOnSameHost()` helper method

* Improve comment clarity.

* Tag `--direct-os-stats` with `hidden` due to deprecation.

* Log warning if deprecated `--direct-os-stats` flag is used.

* Remove `--direct-os-stats` from docs.

* Mention that pgwatch now auto-detects this.

* Add integration test for non-direct os stats via postgresql.

* Improve comments in `IsClientOnSameHost()`

* remove trailing whitespaces

* Ensure `jsonSink` is truncated before test.

---------

Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>

4 of 14 new or added lines in 5 files covered. (28.57%)

3680 of 4994 relevant lines covered (73.69%)

0.84 hits per line