skeema / skeema / 19372770682

92%

Build Type

push

github

Committed by evanelias

Commit Message

tests: refactor integration suite interface

This commit modifies the handling of integration suites in all Skeema
packages as follows:

* Clearer control flow and less "magic". The previous 3-method
  tengo.IntegrationTestSuite interface has now been replaced with a 1-method
  tengo.BeforeTester interface. It is now the caller's responsibility to loop
  over different backend images and call any necessary setup/teardown logic,
  instead of this being part of the test suite interface and runner.

* Satisfying the new tengo.BeforeTester interface is optional; test suites can
  now be any type. This permits potential future use of RunSuite for groups of
  related unit tests, instead of strictly being for integration tests which
  require per-test setup logic.

* Previously, output from successful subtests was always suppressed. Now this
  output can optionally be displayed in real-time by setting env var
  SKEEMA_TEST_VERBOSE=true (or 1 or any other non-falsey value). This may be
  useful for debugging, especially in cases where a newly-written test was
  expected to fail, but it did not.

* Across packages, test suite struct names are now consistent in how they
  intentionally repeat the package name. Normally this is a bad practice with
  naming in Go, but for test output purposes it makes it easier to see which
  package's test suite is currently running. (Most Skeema packages already
  followed this naming scheme, but two previously did not.)

Run Details

47 of 52 new or added lines in 1 file covered. (90.38%)

1 existing line in 1 file now uncovered.

10865 of 11695 relevant lines covered (92.9%)

1.11 hits per line