skeema / skeema / 19153073266

92%

Build Type

push

github

Committed by evanelias

Commit Message

workspaces: run table retries before other sequential statements

This commit slightly refactors the workspace code path which handles retry
logic for CREATE TABLE statements that failed, typically due to FK metadata
locking conflicts when using multiple workspace threads.

In Skeema Premium, it is important to run these retries prior to any other
sequential statements, since e.g. CREATE VIEW statements may rely on these
tables existing after a successful retry. The previous incorrect ordering
caused the non-deterministic problem described in #258, which can be
reproduced when using many FKs, many views referring to the tables with FKs,
and many workspace threads. (Note: triggers were unaffected since their
ordering was already correctly after the table retries; only views had an
incorrect ordering.)

In Skeema Community Edition, this change has no user-facing behavior impact,
but is being made here anyway for codebase alignment purposes.

Run Details

12 of 12 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

10857 of 11689 relevant lines covered (92.88%)

1.11 hits per line