zwave-js / zwave-js-ui / 19337408110

20%

push

github

fix: refresh firmware update availability after update completes (#4457)

Fix firmware update button persistence after successful firmware update

## Summary

After successfully updating a device's firmware, the orange "firmware
update available" button remained visible in the UI, even though there
were no more updates available. The button only disappeared after
restarting the Docker container.

**Root Cause**: The `_onNodeFirmwareUpdateFinished` callback was not
querying for new firmware updates after a firmware update completed,
leaving stale data in the node's `availableFirmwareUpdates` field.

**Solution**: Modified the callback to automatically query for new
firmware updates and refresh the node data, ensuring the UI reflects the
current state immediately.

## Implementation Plan

- [x] Understand the issue and codebase structure
- [x] Modify `_onNodeFirmwareUpdateFinished` to query new firmware
updates
- Added call to `_checkFirmwareUpdatesAfterUpdate` after firmware update
finishes
  - Created new private method `_checkFirmwareUpdatesAfterUpdate`
  - Error handling with logging for any failures
- [x] Build and test the changes
- [x] Run lint and tests to ensure no regressions
- [x] Address code review feedback
- Added check for `disableAutomaticFirmwareUpdateChecks` configuration
option
- Extracted common logic into utility functions to reduce code
duplication:
    - `_filterFirmwareUpdates`: Filter out downgrades
    - `_cleanDismissedUpdates`: Clean up dismissed updates map
- `_updateNodeFirmwareInfo`: Update node firmware info in store and
memory
- Refactored both `checkAllNodesFirmwareUpdates` and
`_checkFirmwareUpdatesAfterUpdate` to use these utilities
- [x] Run security checks with CodeQL
- [x] Document the changes

## Changes Made

1. **Modified `_onNodeFirmwareUpdateFinished` callback**: 
- Added check for `disableAutomaticFirmwareUpdateChecks` before calling
firmware update check
   - Calls `_checkFirmwareUpdatesAfterUpdate` with err... (continued)

333 of 441 branches covered (75.51%)

Branch coverage included in aggregate %.

0 of 120 new or added lines in 1 file covered. (0.0%)

4048 of 21385 relevant lines covered (18.93%)

1.18 hits per line