#20076
89%
master: 89%

Ran 13 Nov 2025 02:53PM UTC

Jobs 1

Files 621

Run time 2min

Badge

Embed ▾

Committed 13 Nov 2025 02:41PM UTC coverage: 88.533% (+0.01%) from 88.522%

Build # #20076

Build Type

push

github

Committed by

ejona86

Commit Message

okhttp: Fix bidirectional keep-alive causing spurious GO_AWAY

When bidirectional keep-alive is enabled (both client and server
sending keep-alive pings), the server incorrectly validates ping
acknowledgments (ACKs) sent in response to server-initiated pings.
This causes the KeepAliveEnforcer strike counter to increment for
legitimate protocol responses, eventually triggering a GO_AWAY with
ENHANCE_YOUR_CALM.

Move the keepAliveEnforcer.pingAcceptable() check inside the !ack
conditional block, so only client-initiated ping requests are
validated. Ping ACKs now bypass enforcement entirely, enabling
bidirectional keep-alive to work correctly.

Fixes #12417

Run Details

34973 of 39503 relevant lines covered (88.53%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.17	-0.14%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
2	82.26	3.23%	../servlet/src/main/java/io/grpc/servlet/ServletAdapter.java
3	93.22	-1.69%	../core/src/main/java/io/grpc/internal/AbstractClientStream.java
3	86.83	-1.23%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20076.1	13 Nov 2025 02:53PM UTC	621	88.53

grpc / grpc-java / #20076
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20076

grpc / grpc-java / #20076 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20076

grpc / grpc-java / #20076
89%
master: 89%

README BADGES
x