tari-project / tari / 19333426770
61%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 702
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 50.497% (-1.0%) from 51.536%
19333426770

push

github

web-flow 
feat: add noreadahead to lmdb as config option  (#7581)

Description
---
Added `open::NORDAHEAD` flag to the LMDB builder as config option.

_"**Quote:** Most operating systems perform readahead on read requests
by default. This option turns it off if the OS supports it. Turning it
off may help random read performance when the DB is larger than RAM and
system RAM is full. The option is not implemented on Windows."_

As per LMDB documentation, this might help with the seed nodes' RAM
usage when needed, or for other Linux users.

Motivation and Context
---
See #7578 for background.

How Has This Been Tested?
---
Not tested.

What process can a PR reviewer use to test or verify this change?
---
Code review.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added a configuration option to control OS readahead behavior for
database storage; can be disabled for performance tuning (defaults
preserve prior behavior).
* **Chores**
  * Storage initialization now respects the new readahead setting.
* **Tests**
  * Internal tests updated to reflect the new configuration parameter.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

21 of 22 new or added lines in 2 files covered. (95.45%)

1256 existing lines in 34 files now uncovered.

57979 of 114817 relevant lines covered (50.5%)

325976.36 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
41.54
 -11.25% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
88.44
 -0.29% comms/core/src/multiplexing/yamux.rs
3
26.09
 -13.04% base_layer/common_types/src/epoch.rs
3
38.57
 -4.29% base_layer/core/src/validation/mocks.rs
3
28.89
 -6.67% base_layer/node_components/src/blocks/block_header_accumulated_data.rs
3
46.51
 -6.98% base_layer/node_components/src/blocks/historical_block.rs
3
81.36
 -1.69% comms/core/src/protocol/rpc/status.rs
3
20.0
 -5.0% infrastructure/test_utils/src/streams/mod.rs
4
0.0
 -23.53% base_layer/core/src/base_node/proto/rpc.rs
4
88.64
 -4.55% base_layer/core/src/test_helpers/block_spec.rs
4
55.88
 0.23% comms/core/src/connectivity/manager.rs
5
71.05
 -6.58% base_layer/core/src/consensus/chain_strength_comparer.rs
5
77.66
 -1.02% comms/core/src/connection_manager/dialer.rs
6
73.53
 -8.82% base_layer/common_types/src/types/fixed_hash.rs
6
55.56
 -22.22% hashing/src/layer2.rs
8
3.47
 -4.62% base_layer/core/src/base_node/state_machine_service/states/events_and_states.rs
8
0.0
 -15.38% base_layer/core/src/validation/error.rs
8
59.33
 -1.12% comms/dht/src/connectivity/mod.rs
9
76.77
 -0.97% base_layer/transaction_components/src/consensus/consensus_constants.rs
11
0.0
 -55.0% base_layer/core/src/base_node/state_machine_service/handle.rs
11
50.0
 -50.0% base_layer/core/src/chain_storage/smt_hasher.rs
12
48.73
 -4.36% base_layer/core/src/chain_storage/db_transaction.rs
12
85.1
 -1.39% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
17
36.47
 -10.0% base_layer/transaction_components/src/transaction_components/output_features.rs
20
0.0
 -26.32% base_layer/transaction_components/src/transaction_components/side_chain/sidechain_feature.rs
21
61.43
 -5.16% base_layer/core/src/chain_storage/lmdb_db/lmdb.rs
21
63.07
 -1.62% base_layer/core/src/test_helpers/blockchain.rs
22
8.7
 -31.88% base_layer/core/src/chain_storage/block_add_result.rs
29
63.75
 -36.25% base_layer/core/src/base_node/sync/rpc/tests.rs
30
0.0
 -28.57% base_layer/transaction_components/src/transaction_components/side_chain/validator_node_registration.rs
39
0.0
 -40.63% base_layer/transaction_components/src/transaction_components/side_chain/validator_node_signature.rs
54
5.12
 -13.17% base_layer/core/src/base_node/rpc/query_service.rs
55
12.27
 -14.36% base_layer/core/src/base_node/sync/rpc/service.rs
341
41.54
 -11.25% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
475
38.96
 -16.49% base_layer/core/src/chain_storage/blockchain_database.rs
Jobs
ID Job ID Ran Files Coverage
1 19333426770.1 702
50.5
 GitHub Action Run
Source Files on build 19333426770