19333426770

Committed 13 Nov 2025 01:37PM UTC coverage: 50.497% (-1.0%) from 51.536%

Build # 19333426770

Build Type

push

github

Committed by

web-flow

Commit Message

feat: add noreadahead to lmdb as config option  (#7581)

Description
---
Added `open::NORDAHEAD` flag to the LMDB builder as config option.

_"**Quote:** Most operating systems perform readahead on read requests
by default. This option turns it off if the OS supports it. Turning it
off may help random read performance when the DB is larger than RAM and
system RAM is full. The option is not implemented on Windows."_

As per LMDB documentation, this might help with the seed nodes' RAM
usage when needed, or for other Linux users.

Motivation and Context
---
See #7578 for background.

How Has This Been Tested?
---
Not tested.

What process can a PR reviewer use to test or verify this change?
---
Code review.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added a configuration option to control OS readahead behavior for
database storage; can be disabled for performance tuning (defaults
preserve prior behavior).
* **Chores**
  * Storage initialization now respects the new readahead setting.
* **Tests**
  * Internal tests updated to reflect the new configuration parameter.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Run Details

21 of 22 new or added lines in 2 files covered. (95.45%)

1256 existing lines in 34 files now uncovered.

57979 of 114817 relevant lines covered (50.5%)

325976.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

46.51

/base_layer/node_components/src/blocks/historical_block.rs

//  Copyright 2021, The Tari Project
//
//  Redistribution and use in source and binary forms, with or without modification, are permitted provided that the
//  following conditions are met:
//
//  1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following
//  disclaimer.
//
//  2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the
//  following disclaimer in the documentation and/or other materials provided with the distribution.
//
//  3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote
//  products derived from this software without specific prior written permission.
//
//  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
//  INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
//  DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
//  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
//  SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
//  WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
//  USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

use std::{fmt, fmt::Display, sync::Arc};

use tari_common_types::types::HashOutput;

use crate::blocks::{error::BlockError, Block, BlockHeader, BlockHeaderAccumulatedData, ChainBlock};

/// The representation of a historical block in the blockchain. It is essentially identical to a protocol-defined
/// block but contains some extra metadata that clients such as Block Explorers will find interesting.
#[derive(Debug, Clone, PartialEq)]
pub struct HistoricalBlock {
    /// The number of blocks that have been mined since this block, including this one. The current tip will have one
    /// confirmation.
    confirmations: u64,
    /// The underlying block
    block: Block,
    /// Accumulated data in the block header
    accumulated_data: BlockHeaderAccumulatedData,
}

impl HistoricalBlock {
    pub fn new(block: Block, confirmations: u64, accumulated_data: BlockHeaderAccumulatedData) -> Self {
        HistoricalBlock {
            confirmations,
            block,
            accumulated_data,
        }
    }

    pub fn confirmations(&self) -> u64 {
        self.confirmations
    }

    pub fn header(&self) -> &BlockHeader {
        &self.block.header
    }

    /// Returns a reference to the block of the HistoricalBlock
    pub fn block(&self) -> &Block {
        &self.block
    }

    pub fn into_block(self) -> Block {
        self.block
    }

    pub fn accumulated_data(&self) -> &BlockHeaderAccumulatedData {
        &self.accumulated_data
    }

    pub fn hash(&self) -> &HashOutput {
        &self.accumulated_data.hash
    }

    pub fn try_into_chain_block(self) -> Result<ChainBlock, BlockError> {
        let chain_block = ChainBlock::try_construct(Arc::new(self.block), self.accumulated_data).ok_or_else(|| {
            BlockError::ChainBlockInvariantError(
                "Unable to construct ChainBlock because of a hash mismatch".to_string(),
            )
        })?;

        Ok(chain_block)
    }

    pub fn dissolve(self) -> (Block, BlockHeaderAccumulatedData, u64) {
        (self.block, self.accumulated_data, self.confirmations)
    }
}

impl Display for HistoricalBlock {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        writeln!(f, "{}", self.block())?;
        Ok(())
    }
}

impl From<HistoricalBlock> for Block {
    fn from(block: HistoricalBlock) -> Self {
        block.block
    }
}

1	// Copyright 2021, The Tari Project
2	//
3	// Redistribution and use in source and binary forms, with or without modification, are permitted provided that the
4	// following conditions are met:
5	//
6	// 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following
7	// disclaimer.
8	//
9	// 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the
10	// following disclaimer in the documentation and/or other materials provided with the distribution.
11	//
12	// 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote
13	// products derived from this software without specific prior written permission.
14	//
15	// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
16	// INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17	// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
18	// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
19	// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
20	// WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
21	// USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
22
23	use std::{fmt, fmt::Display, sync::Arc};
24
25	use tari_common_types::types::HashOutput;
26
27	use crate::blocks::{error::BlockError, Block, BlockHeader, BlockHeaderAccumulatedData, ChainBlock};
28
29	/// The representation of a historical block in the blockchain. It is essentially identical to a protocol-defined
30	/// block but contains some extra metadata that clients such as Block Explorers will find interesting.
31	#[derive(Debug, Clone, PartialEq)]
32	pub struct HistoricalBlock {
33	/// The number of blocks that have been mined since this block, including this one. The current tip will have one
34	/// confirmation.
35	confirmations: u64,
36	/// The underlying block
37	block: Block,
38	/// Accumulated data in the block header
39	accumulated_data: BlockHeaderAccumulatedData,
40	}
41
42	impl HistoricalBlock {
43	pub fn new(block: Block, confirmations: u64, accumulated_data: BlockHeaderAccumulatedData) -> Self {	71✔
44	HistoricalBlock {	71✔
45	confirmations,	71✔
46	block,	71✔
47	accumulated_data,	71✔
48	}	71✔
49	}	71✔
50
51	pub fn confirmations(&self) -> u64 {	×
52	self.confirmations	×
53	}	×
54
55	pub fn header(&self) -> &BlockHeader {	2✔
56	&self.block.header	2✔
57	}	2✔
58
59	/// Returns a reference to the block of the HistoricalBlock
60	pub fn block(&self) -> &Block {	35✔
61	&self.block	35✔
62	}	35✔
63
64	pub fn into_block(self) -> Block {	18✔
65	self.block	18✔
66	}	18✔
67
UNCOV 68	pub fn accumulated_data(&self) -> &BlockHeaderAccumulatedData {	×
UNCOV 69	&self.accumulated_data	×
UNCOV 70	}	×
71
72	pub fn hash(&self) -> &HashOutput {	×
73	&self.accumulated_data.hash	×
74	}	×
75
76	pub fn try_into_chain_block(self) -> Result<ChainBlock, BlockError> {	36✔
77	let chain_block = ChainBlock::try_construct(Arc::new(self.block), self.accumulated_data).ok_or_else(\|\| {	36✔
78	BlockError::ChainBlockInvariantError(	×
79	"Unable to construct ChainBlock because of a hash mismatch".to_string(),	×
80	)	×
81	})?;	×
82
83	Ok(chain_block)	36✔
84	}	36✔
85
86	pub fn dissolve(self) -> (Block, BlockHeaderAccumulatedData, u64) {	×
87	(self.block, self.accumulated_data, self.confirmations)	×
88	}	×
89	}
90
91	impl Display for HistoricalBlock {
92	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {	×
93	writeln!(f, "{}", self.block())?;	×
94	Ok(())	×
95	}	×
96	}
97
98	impl From<HistoricalBlock> for Block {
99	fn from(block: HistoricalBlock) -> Self {	×
100	block.block	×
101	}	×
102	}

tari-project / tari / 19333426770

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous