Alan-Jowett / bdd_test / 19312751349

88%

push

github

Fix CUDD iterator interface and test assumptions for canonical BDD output (#45)

* Initial plan

* Re-enable unit tests for CUDD/TeDDy comparison - tests pass

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix CUDD iterator to use canonical IDs and update tests

- Remove non-canonical get_dot_node_id(), get_mermaid_node_id() methods
- Remove unused get_low_child_id(), get_high_child_id() methods
- These methods used memory addresses, producing non-deterministic output
- Update tests to allow different node counts (CUDD optimizes better)
- Add determinism test to verify canonical output
- All tests now pass

Signed-off-by: GitHub Copilot <copilot@github.com>

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add CUDD determinism verification script and update gitignore

- Add verification script to test canonical output
- Update .gitignore to exclude CodeQL build artifacts
- All tests pass confirming deterministic behavior

Signed-off-by: GitHub Copilot <copilot@github.com>

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix unit test working directory configuration

- Set WORKING_DIRECTORY to CMAKE_SOURCE_DIR for catch_discover_tests
- Update custom test targets to use project root
- All 97 tests now pass from build directory
- Fixes issue where tests couldn't find test_expressions files

Signed-off-by: GitHub Copilot <copilot@github.com>

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add comprehensive documentation for CUDD canonical output fix

- Document all fixes and rationale
- Explain why different node counts are valid
- Provide verification results and examples
- Reference BDD theory and implementation details

Signed-off-by: GitHub Copilot <copilot@github.com>

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Changes before error encountered

Co-authored-by: Alan-Jowett <20480683+Alan-Jow... (continued)

1274 of 1702 branches covered (74.85%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

1150 of 1366 relevant lines covered (84.19%)

73001.45 hits per line