#20070
89%

Ran 12 Nov 2025 09:26PM UTC

Jobs 1

Files 624

Run time 37min

Badge

Embed ▾

Committed 12 Nov 2025 09:14PM UTC coverage: 88.606% (+0.02%) from 88.589%

Build # #20070

Build Type

push

github

Committed by

ejona86

Commit Message

okhttp: Fix bidirectional keep-alive causing spurious GO_AWAY

When bidirectional keep-alive is enabled (both client and server
sending keep-alive pings), the server incorrectly validates ping
acknowledgments (ACKs) sent in response to server-initiated pings.
This causes the KeepAliveEnforcer strike counter to increment for
legitimate protocol responses, eventually triggering a GO_AWAY with
ENHANCE_YOUR_CALM.

Move the keepAliveEnforcer.pingAcceptable() check inside the !ack
conditional block, so only client-initiated ping requests are
validated. Ping ACKs now bypass enforcement entirely, enabling
bidirectional keep-alive to work correctly.

Fixes #12417

Run Details

35120 of 39636 relevant lines covered (88.61%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	75.26	-3.09%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20070.1	12 Nov 2025 09:26PM UTC	624	88.61

grpc / grpc-java / #20070
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20070

grpc / grpc-java / #20070 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20070

grpc / grpc-java / #20070
89%

README BADGES
x