#20067
89%

Ran 12 Nov 2025 07:46PM UTC

Jobs 1

Files 624

Run time 2min

Badge

Embed ▾

Committed 12 Nov 2025 07:34PM UTC coverage: 88.522% (-0.03%) from 88.552%

Build # #20067

Build Type

push

github

Committed by

web-flow

Commit Message

core: Release lock before closing shared resource

If a resource has dependencies that also use SharedResourceHolder, and
its close() blocks waiting for processing on another thread, then the
threads could become deadlocked on the SharedResourceHolder lock. Our
answer should be "don't block," but it's also good to avoid calling
arbitrary code with a lock held.

create() is still called with the lock held, but that seems less likely
to do work on another thread, and it is harder to avoid the lock.
close() is very easy to call without the lock.

See d50098f80 and b/458736211

Run Details

35069 of 39616 relevant lines covered (88.52%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	47.62	-4.76%	../core/src/main/java/io/grpc/internal/PickSubchannelArgsImpl.java
1	97.73	-2.27%	../core/src/main/java/io/grpc/internal/SharedResourceHolder.java
1	87.88	-3.03%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
1	93.17	-0.14%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
3	92.38	-0.95%	../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
5	86.01	-2.06%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20067.1	12 Nov 2025 07:46PM UTC	624	88.52

grpc / grpc-java / #20067
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20067

grpc / grpc-java / #20067 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20067

grpc / grpc-java / #20067
89%

README BADGES
x