Unleash / unleash / 19295143890

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: allow external flag resolver to override false experiments with variants in getAll (#10966)

Fixes a bug / uncovered edge case in the flag resolver in Unleash:
If a local experiment was defined as false (the typical default value),
then that flag could only ever be returned as a boolean from the
`ui-config` endpoint. In other words, even if the external resolver has
a variant for that flag, the UI would never get the variant.

The fix is to not just check `isEnabled` for false flags, but instead:
- use `getVariant`
- then check `variant.enabled` (in which case we have a variant and can
return it)
- else check `variant.feature_enabled`, falling back to `isEnabled` only
if `feature_enabled` is null/undefined.

Run Details

7231 of 7283 branches covered (99.29%)

8 of 8 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

68925 of 75621 relevant lines covered (91.15%)

442.56 hits per line