zwave-js / zwave-js-ui / 19273323451

20%

push

github

fix(ui): add null check in setRoute to handle cancelled dialog (#4450)

When setting a priority route, cancelling the dialog caused a
destructuring error that prevented the operation from completing.

## Changes

- Added null check in `NodePanel.vue` `setRoute` method after
`promptRoute` call
- Function now returns early if user cancels dialog instead of
attempting to destructure null

```javascript
const res = await this.promptRoute(prefix, suffix)

if (!res) return  // Handle cancellation

const { repeaters, routeSpeed } = res
```


<!-- START COPILOT CODING AGENT SUFFIX -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>fix(ui): unable to set direct controller connection when
setting priority route</issue_title>
> <issue_description>When setting a priority route if you don't set any
repeater the request is not sent to backend
> 
> ### Discussed in
https://github.com/zwave-js/zwave-js-ui/discussions/4447
> </issue_description>
> 
> <agent_instructions>The issue should be in `setRoute` method in
NodePanel.vue</agent_instructions>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> </comments>
> 


</details>

<!-- START COPILOT CODING AGENT TIPS -->
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: robertsLando <11502495+robertsLando@users.noreply.github.com>
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>

333 of 441 branches covered (75.51%)

Branch coverage included in aggregate %.

4048 of 21310 relevant lines covered (19.0%)

1.18 hits per line