kobotoolbox / kpi / 19261281535

81%

master: 76%

push

github

feat(formBuilder): add default max-pixels value when adding new photo question DEV-966 (#6444)

### 📣 Summary

When creating `image` question in Form Builder, set `max-pixels` to
default value (`1024`) instead of leaving it blank. Also applies default
values for `range` question type (the change is universal and will work
with any future default values we set).

### 💭 Notes

Changes here:
- Added bunch of comments while trying to understand the code
- All predefined `defaultValue`s of parameters will be applied when
question is being created (currently we have those for `image` and
`range`)
- **NO** allowing to remove `max-pixels` from `image` (will be done as
part of separate linear issue)

### 👀 Preview steps

1. ℹ️ Have an account
2. Create a new form in Form Builder
3. Add `image` question
4. **Do not open the question Settings**
5. Save form
6. Go to Project → Form page (`/landing`)
7. Use "Download XLS" from top right "…" ("More actions") dropdown
8. 🔴 [on main] notice that downloaded file has no `max-pixels` value for
the question in the "parameters" column
9. 🟢 [on PR] notice that downloaded file has `max-pixels` for the
quesion

7095 of 11146 branches covered (63.66%)

27405 of 33699 relevant lines covered (81.32%)

1.6 hits per line