gimli-rs / gimli / 19252490893

89%

Build Type

push

github

Committed by web-flow

Commit Message

Reduce the size of `UnitSectionOffset` (#825)

Change `UnitSectionOffset` from an enum to a simple newtype, and store a
`SectionId` in `read::UnitHeader` instead.

`UnitSectionOffset` is intended for code that may be handling either
`.debug_info` or `.debug_types`. However, you will usually have a
`UnitHeader` you can use to determine the section type.

This significantly reduces the memory usage in the conversion code,
where we need to store an offset for every entry in the section.

This required some changes to the `UnitSectionOffset` methods. To make
things more consistent, I also changed these methods to use `UnitHeader`
instead of `Unit`, and added a `Deref` impl to `Unit`.

Run Details

40 of 89 new or added lines in 7 files covered. (44.94%)

5 existing lines in 4 files now uncovered.

6745 of 12231 relevant lines covered (55.15%)

1.41 hits per line