|
Ran
|
Jobs
3
|
Files
1174
|
Run time
3min
|
Badge
README BADGES
|
push
github
web: migrate to React Router v7 (#2861) ## Problem React Router v7 was released almost a year now (see https://reactrouter.com/changelog#v700), but it has not been updated in Agama yet. In addition to the obvious benefit of keeping dependencies up-to-date, updating it might help to address some limitations we have found with the v6 version, like https://github.com/agama-project/agama/pull/2767/commits/06d858cba ## Solution Migrate React Router dependency to its latest version. ## Testing - Adapted existing tests. ## Notes This migration has been straightforward, and as of now, Agama is using Data Mode (see https://reactrouter.com/start/modes). However, this could change in the future if we find advantages in switching to Declarative or Framework Mode. Before making any decisions, we’ll need to work on `src/App.tsx` along with the changes planned for the api-v2 branch that this PR is based on. ## Documentation * https://reactrouter.com/upgrading/v6 * https://github.com/remix-run/react-router/issues/12363#issuecomment-2496226528 * https://github.com/remix-run/react-router/pull/13530 (`generatePath` now encodes URL params by default, related to https://github.com/agama-project/agama/pull/2576) * https://www.typescriptlang.org/tsconfig/#moduleResolution
2695 of 4694 branches covered (57.41%)
Branch coverage included in aggregate %.
55 of 63 new or added lines in 52 files covered. (87.3%)
53 existing lines in 7 files now uncovered.25680 of 39111 relevant lines covered (65.66%)
150.86 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
87.5 |
-0.38% | web/src/components/network/WiredConnectionsList.tsx |
| 1 |
34.29 |
-1.83% | web/src/components/storage/FilesystemMenu.tsx |
| 1 |
61.29 |
-1.21% | web/src/components/storage/SpacePolicyMenu.tsx |
| 1 |
0.0 |
0.0% | web/src/index.tsx |
| 2 |
39.13 |
-2.54% | web/src/components/storage/UnusedMenu.tsx |
| 2 |
36.92 |
-0.96% | web/src/components/storage/VolumeGroupEditor.tsx |
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 2 |
95.65 |
-0.57% | web/web/src/utils.ts |
| 2 |
92.86 |
-0.25% | web/web/src/components/network/WiredConnectionsList.tsx |
| 6 |
40.91 |
-2.57% | web/web/src/components/storage/UnusedMenu.tsx |
| 7 |
65.52 |
-1.15% | web/web/src/components/storage/SpacePolicyMenu.tsx |
| 8 |
82.28 |
-0.22% | web/web/src/components/storage/PartitionsMenu.tsx |
| 9 |
37.5 |
-1.89% | web/web/src/components/storage/FilesystemMenu.tsx |
| 19 |
40.0 |
-0.98% | web/web/src/components/storage/VolumeGroupEditor.tsx |
| ID | Flag name | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|---|
| 3 | web | 19247064332.3 | 580 |
68.68 |
GitHub Action Run | |
| 1 | rust | 19142909161.1 | 204 |
24.96 |
GitHub Action Run | |
| 3 | service | 18222230338.3 | 390 |
88.57 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|