goto / guardian / 19136755093

66%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add summary support to ListAppeals apis & support bot user grant for guardian package (#238)

* Preload approvers in approval list query

Added Preload for 'Appeal.Approvals.Approvers' in the ListApprovals method to ensure approver data is loaded with approvals. This enables access to approver details when listing approvals.

* Add summary support to ListAppeals endpoints

Extended ListAppeals and ListUserAppeals handlers, filters, and proto definitions to support summary queries and results. Updated appeal service interface and mocks to include GenerateSummary, and refactored filter construction for more flexible querying. This enables clients to request grouped and unique summary data along with appeals.

* Fix incorrect request field mapping in appeal handlers

Corrects the mapping of ProviderTypes and ResourceTypes fields in ListUserAppeals and ListAppeals handlers to use the appropriate request getters. This ensures accurate filtering based on provider and resource types.

* Reorder GORM preload calls in ListApprovals

Changed the order of Preload calls in the ListApprovals method to preload Appeal.Resource before Appeal.Approvals and its Approvers. This may improve query efficiency or resolve data loading issues.

* Fix total count queries to omit pagination and ordering

Updated GetAppealsTotalCount, GetApprovalsTotalCount, and GetGrantsTotalCount to explicitly omit offset, size, and order_by from filters before counting. This ensures accurate total counts unaffected by pagination or ordering parameters.

* Refactor ValidateAppeal logic for package resources

Improves the ValidateAppeal method by restructuring logic for package-type resources and separating handling for bot and user account types. Adds a nil resource check and clarifies error handling for missing account information.

* Add docs

* Fix grant logic to use AccountType instead of Role

Replaces the switch statement in GetDependencyGrants to use g.AccountType instead of g.Rol... (continued)

Run Details

159 of 231 new or added lines in 8 files covered. (68.83%)

2 existing lines in 2 files now uncovered.

11533 of 17069 relevant lines covered (67.57%)

4.58 hits per line