hustcc / echarts-for-react / 19122124500

95%

push

github

Only unbind events passed from the parent component (#613)

`initEchartsInstance` attached a handler for the `"finish"` event. If
`componentDidUpdate` is called between attaching the handler, and firing
the handler and the `onEvents` prop changed, this will fire
`"offEvents"` which will remove the handler for the `"finish"` event.
This means the finish handler never fires, so the chart auto-resize is
not attached, and the ready event handler never fires.

Instead, only remove the events that are on the previous props, and
leave the `"finish"` callback alone.

1 of 2 branches covered (50.0%)

Branch coverage included in aggregate %.

17 of 17 relevant lines covered (100.0%)

6.71 hits per line