hustcc / echarts-for-react

95%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• chore-new-verison
• chore-v3-stable
• docs-readme
• fix-ci
• fix-size-sensor
• fix/finish-event-race-condition
• fix/options-type-incompatibility
• fix/unbind-listeners
• hustcc-patch-1
• master
• refs/tags/3.0.0-beta.1
• refs/tags/3.0.0-beta.2
• refs/tags/3.0.3
• refs/tags/v3.0.0
• refs/tags/v3.0.1
• refs/tags/v3.0.2
• refs/tags/v3.0.3
• refs/tags/v3.0.4
• refs/tags/v3.0.5
• update-deps
• update-dumi-base
• v1.3.5
• v1.4.0
• v1.4.1
• v2
• v2.0.10
• v2.0.12
• v2.0.16
• v2.0.5
• v2.0.6
• v2.0.7
• v2.0.8
• v2.x
• v3
• ver-beta.2

Build # 21197187486

Build Type

push

github

Committed by web-flow

Commit Message

Clean up event listeners from previous renders (#618)

* Add second test series

This makes it possible to dispatch legend events for testing.

* Add test case

This verifies the bug by adding a failing test case. On re-render there
are two event listeners attached to the chart instance, there should be
only one!

* Correctly unbind the current event handlers

Keep track of the handlers added to the current instance. Unbind them
before binding new events.

* Rename onEvents to eventHandlerRefs for clarity

* Bump version from 3.0.5 to 3.0.6

---------

Co-authored-by: hustcc <i@hust.cc>

Run Details

1 of 2 branches covered (50.0%)

Branch coverage included in aggregate %.

17 of 17 relevant lines covered (100.0%)

8.59 hits per line