kobotoolbox / kpi / 18969109081

81%

master: 76%

push

github

feat(downloads): allow safe whitelisted MIME types to render inline; keep others as attachments DEV-1207 (#6421)

### 📣 Summary
Reverts the forced download behavior introduced in #6407 and allows safe
file types (such as images, audio, and video) to open directly in the
browser again, while keeping potentially unsafe files downloaded
instead.

### 📖 Description
Some media types (e.g., SVG) can embed active content and should not be
rendered in the browser by default. This change replaces the
one-size-fits-all Content-Disposition: attachment header with a safer,
smarter policy: if a file’s detected MIME type is in a maintained
allowlist of safe types, the response is sent with Content-Disposition:
inline so users can view it directly; otherwise, it remains attachment.

6936 of 10950 branches covered (63.34%)

8 of 8 new or added lines in 3 files covered. (100.0%)

26756 of 32983 relevant lines covered (81.12%)

1.6 hits per line