tari-project / tari / 18936078418

62%

Build Type

push

github

Committed by web-flow

Commit Message

fix: multi_address_with_stats merging to only retain the newest valid claims in the peer_db (#7535)

Description
---
The peer_db now only retains the latest claims, and peer multi-address
merges cleans out old data.

Closes #7491.

Motivation and Context
---
See #7491.

How Has This Been Tested?
---
Added new unit tests:
- MultiAddressWithStats
  - `fn it_merges_addresses_with_stats_correctly()`
  - `fn it_merges_when_config_overlaps()`
  - `fn it_prefers_advertised_addresses_over_config_on_tie()`
- PeerManager
  - `async fn it_correctly_merges_old_and_new_address_claims()`

System-level testing.

What process can a PR reviewer use to test or verify this change?
---
Code review.
System-level testing.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- New Features
- Claim-aware peer address merging that prefers newer signed claims,
preserves configured addresses, enforces capacity limits, and
deterministically breaks ties in favor of advertised addresses.
- Batch-style address updates with automatic pruning of stale addresses
to keep peers’ address lists current.

- Bug Fixes
- Eliminates inconsistent ordering, duplicates, and outdated addresses
after updates; preserves and propagates usage/latency stats correctly.

- Documentation
  - Clarified merge, replacement, and tie-breaking behavior.

- Tests
- Added tests for claim timestamps, m... (continued)

Run Details

344 of 353 new or added lines in 7 files covered. (97.45%)

9 existing lines in 4 files now uncovered.

67926 of 113879 relevant lines covered (59.65%)

302582.71 hits per line