tari-project / tari / 18934144103
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 700
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.547% (-0.02%) from 59.571%
18934144103

push

github

web-flow 
fix: windows test build target link (#7559)

Description
---
Fixed the issue with the Windows test build target link:
```
: error LNK2019: unresolved external symbol __imp_InitializeSecurityDescriptor referenced in function mdb_env_setup_locks
: error LNK2019: unresolved external symbol __imp_SetSecurityDescriptorDacl referenced in function mdb_env_setup_lock
```

Motivation and Context
---
Release mode tests in Windows could not be run. Something somewhere in
the lmdb dependencies omitted the rustflags.

How Has This Been Tested?
---
Release mode tests in Windows could be run.

What process can a PR reviewer use to test or verify this change?
---
Code review.
Run release mode tests in Windows.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Chores
* Added Windows MSVC build target configuration to optimize system
library linking during the compilation process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

67661 of 113627 relevant lines covered (59.55%)

304344.66 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
93.76
 -0.19% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
47.66
 -0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
2
55.76
 -0.23% comms/core/src/connectivity/manager.rs
4
35.56
 -3.47% base_layer/node_components/src/blocks/block_header_accumulated_data.rs
5
59.47
 -0.7% comms/dht/src/connectivity/mod.rs
13
46.58
 0.0% base_layer/core/src/chain_storage/async_db.rs
62
85.34
 0.1% comms/dht/src/actor.rs
75
64.7
 -0.29% base_layer/core/src/test_helpers/blockchain.rs
207
52.79
 -0.38% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
415
55.45
 -0.21% base_layer/core/src/chain_storage/blockchain_database.rs
Jobs
ID Job ID Ran Files Coverage
1 18934144103.1 700
59.55
 GitHub Action Run
Source Files on build 18934144103