18897389844
83%

Ran 29 Oct 2025 05:51AM UTC

Jobs 1

Files 60

Run time 1min

Badge

Embed ▾

Committed 28 Oct 2025 05:07PM UTC coverage: 84.699% (-1.2%) from 85.946%

Build # 18897389844

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Default to allowing binary stream snapshots (#7479)

When routes to other servers are established `binarySnapshots` is
initially set to `false` indicating it is not supported. Then once a
`STATSZ` is received `binarySnapshots` will be updated to `true`.

Whether this server supports binary snapshots is determined by looping
over the peers and checking if other servers don't support it:
```
if sir, ok := s.nodeToInfo.Load(p.ID); ok && sir != nil && !sir.(nodeInfo).binarySnapshots
```

However, there's an issue here as the server will shortly think
`binarySnapshots` isn't supported and go back to the legacy snapshot
which contains interior deletes as a `[]uint64` which will be disastrous
if a stream has a huge amount of interior deletes. Since binary stream
snapshots are supported since 2.10.0, we can simply flip the
`binarySnapshots` default from `false` to `true`.

Alternative to https://github.com/nats-io/nats-server/pull/7476

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Coverage Stats

73606 of 86903 relevant lines covered (84.7%)

352905.72 hits per line

Coverage Regressions

Lines	Coverage	∆	File
848	82.43	-0.06%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
546	79.6	-2.03%	src/github.com/nats-io/nats-server/server/opts.go
281	90.21	-4.02%	src/github.com/nats-io/nats-server/server/server.go
281	70.04	-26.07%	src/github.com/nats-io/nats-server/server/websocket.go
151	57.11	-31.59%	src/github.com/nats-io/nats-server/server/subject_transform.go
121	87.61	0.46%	src/github.com/nats-io/nats-server/server/raft.go
114	87.97	-9.08%	src/github.com/nats-io/nats-server/server/sublist.go
84	19.85	-61.76%	src/github.com/nats-io/nats-server/server/signal.go
52	90.23	-0.67%	src/github.com/nats-io/nats-server/server/reload.go
39	90.08	-0.15%	src/github.com/nats-io/nats-server/server/leafnode.go
39	84.29	-2.04%	src/github.com/nats-io/nats-server/server/memstore.go
36	64.45	-7.03%	src/github.com/nats-io/nats-server/server/dirstore.go
36	93.46	-0.21%	src/github.com/nats-io/nats-server/server/route.go
34	83.37	-0.29%	src/github.com/nats-io/nats-server/server/filestore.go
27	94.57	-0.58%	src/github.com/nats-io/nats-server/server/client.go
19	85.78	-9.31%	src/github.com/nats-io/nats-server/server/util.go
18	88.13	-1.45%	src/github.com/nats-io/nats-server/server/auth.go
18	72.8	-0.37%	src/github.com/nats-io/nats-server/server/jetstream_api.go
16	88.94	-0.4%	src/github.com/nats-io/nats-server/server/mqtt.go
15	78.92	-4.52%	src/github.com/nats-io/nats-server/server/store.go
12	93.84	-0.41%	src/github.com/nats-io/nats-server/server/gateway.go
7	86.4	-0.09%	src/github.com/nats-io/nats-server/server/events.go
5	46.15	-38.46%	src/github.com/nats-io/nats-server/server/const.go
4	88.23	0.09%	src/github.com/nats-io/nats-server/server/consumer.go
4	42.86	-57.14%	src/github.com/nats-io/nats-server/server/service.go
3	81.01	-3.8%	src/github.com/nats-io/nats-server/server/errors.go
2	63.16	-10.53%	src/github.com/nats-io/nats-server/server/jetstream_events.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	18897389844.1	29 Oct 2025 05:51AM UTC	60	84.7	GitHub Action Run

nats-io / nats-server / 18897389844
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 18897389844

nats-io / nats-server / 18897389844 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 18897389844

nats-io / nats-server / 18897389844
83%

README BADGES
x