iotaledger / iota / 18894261097
64%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1437
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.023% (-0.03%) from 66.055%
18894261097

push

github

web-flow 
refactor(indexer): Split primary and snapshot executors (#8916)

# Description of change

This PR splits executors for Primary and Snapshot pipelines in case it's
possible (so in situation where user passes the remote_store_url as the
source of checkpoints).
The code was refactored to leverage the fact that those are separate
pipelines with separate executors.

## Links to any relevant issues

fixes https://github.com/iotaledger/iota/issues/8841

## How the change has been tested

colocated setup tested with `iota start` command
non colocated setup tested by running `iota start` and starting indexer
separately
sync from genesis for mainnet data was NOT tested yet

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)

### Infrastructure QA (only required for crates that are maintained by
@iotaledger/infrastructure)

- [ ] Synchronization of the indexer from genesis for a network
including migration objects.
- [ ] Restart of indexer synchronization locally without resetting the
database.
- [ ] Restart of indexer synchronization on a production-like database.
- [ ] Deployment of services using Docker.
- [ ] Verification of API backward compatibility.

### Release Notes

- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [x] Indexer:
Passing `--remote-store-url` as the source of checkpoints will run the
snapshot indexing pipeline using a separate executor, allowing much
bigger config parameters for snapshot lag.
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] REST API:

0 of 296 new or added lines in 4 files covered. (0.0%)

48 existing lines in 15 files now uncovered.

234727 of 355525 relevant lines covered (66.02%)

2372775.46 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
24
0.0
 crates/iota-indexer/src/ingestion/common/orchestration.rs
56
0.0
 0.0% crates/iota-indexer/src/indexer.rs
79
0.0
 0.0% crates/iota-indexer/src/ingestion/primary/orchestration.rs
137
0.0
 0.0% crates/iota-indexer/src/ingestion/snapshot/orchestration.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
87.19
 0.13% consensus/core/src/synchronizer.rs
1
84.78
 -0.05% crates/iota-core/src/authority/authority_per_epoch_store.rs
1
89.69
 0.0% crates/iota-core/src/connection_monitor.rs
1
0.0
 0.0% crates/iota-indexer/src/indexer.rs
1
0.0
 0.0% crates/iota-indexer/src/ingestion/snapshot/orchestration.rs
1
86.67
 0.13% crates/iota-network/src/discovery/mod.rs
1
74.83
 0.0% crates/iota-types/src/crypto.rs
1
84.77
 -0.51% crates/starfish/core/src/leader_timeout.rs
2
57.04
 -0.47% crates/iota-core/src/storage.rs
2
75.53
 -1.06% crates/iota-grpc-server/src/types.rs
2
66.67
 -4.17% crates/iota-network-stack/src/anemo_ext.rs
5
87.77
 -0.68% crates/iota-core/src/epoch/randomness.rs
5
90.61
 -0.11% crates/starfish/core/src/synchronizer.rs
10
70.84
 -0.85% crates/iota-core/src/authority/authority_store.rs
14
0.0
 -48.28% crates/iota-types/src/storage/error.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 18894261097.1 1439
66.01
 GitHub Action Run
Source Files on build 18894261097